Repository navigation
docs: correct Store build and WACK verification instructions - #4
Merged
Merged
Conversation
Generated-with: gpt-6.1-sol (Codex)
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public Store build guide required Python 3.11 although the package requires 3.12+, invoked an unavailable private workstation script, promised a different EXE output and verification behavior, and described a static material preflight as WACK certification.
Document the actual external scanner prerequisite, explicit output override and staging requirement. Replace private absolute commands with repository-relative Windows SDK packaging, retain SDK validation, and distinguish static preflight reports from separately executed WACK and Store certification.
Validation: all 11 existing Store-material tests pass on Windows Python 3.12; git diff --check passes. Instructions were checked against pyproject.toml, build_exe.bat and scripts/run_windows_wack.py. No executable/MSIX was built, signed, certified or submitted. No product version or runtime behavior changed.
This is a scoped documentation correction found during care preflight, not a claim of completed full repository care. Other care findings remain outside this PR. Author model: gpt-6.1-sol (Codex). Independent model review pending. Draft only; merges disabled.